Only support batch butex wake with the same tag#2778
Merged
Conversation
Contributor
|
这个修改对性能有影响吗？ |
Contributor
Author
对性能没有影响，默认butex的唤醒就是每个waiter都会signal的，只有使用CountdownEvent的时候，主动设置了void signal(int sig = 1, bool flush = false); flush=true才会有相关的影响。 |
Contributor
|
持续集成失败和改动有关吗？ |
yanglimingcn
force-pushed
the
bugfix/butex_batch_wake
branch
from
15b3368 to
b16bc11
Compare
Contributor
Author
看上去不相关，主要是streaming那个case报错，我本地跑这个case没问题。 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2777
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: